Skip to content

GROOVY-7439: allow logging transform on trait class#2220

Merged
eric-milles merged 1 commit into
masterfrom
GROOVY-7439
May 12, 2025
Merged

GROOVY-7439: allow logging transform on trait class#2220
eric-milles merged 1 commit into
masterfrom
GROOVY-7439

Conversation

@eric-milles
Copy link
Copy Markdown
Member

Let @Log, etc. apply to trait class and run before trait transform.

@eric-milles eric-milles requested a review from paulk-asert May 9, 2025 14:58
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 9, 2025

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.0047%. Comparing base (5916bc5) to head (1c21cf9).
⚠️ Report is 740 commits behind head on master.

Files with missing lines Patch % Lines
...ansform/ASTTransformationCollectorCodeVisitor.java 75.0000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2220        +/-   ##
==================================================
+ Coverage     68.9931%   69.0047%   +0.0116%     
- Complexity      29660      29667         +7     
==================================================
  Files            1423       1423                
  Lines          114323     114327         +4     
  Branches        19832      19832                
==================================================
+ Hits            78875      78891        +16     
+ Misses          28815      28809         -6     
+ Partials         6633       6627         -6     
Files with missing lines Coverage Δ
...aus/groovy/transform/ASTTransformationVisitor.java 81.8182% <100.0000%> (ø)
...aus/groovy/transform/BuilderASTTransformation.java 62.8571% <100.0000%> (ø)
...ransform/ExternalizeVerifierASTTransformation.java 92.1053% <100.0000%> (ø)
...odehaus/groovy/transform/LogASTTransformation.java 68.0672% <100.0000%> (+0.2706%) ⬆️
...us/groovy/transform/SortableASTTransformation.java 96.7742% <ø> (ø)
...groovy/transform/trait/TraitASTTransformation.java 90.9375% <100.0000%> (ø)
...ansform/ASTTransformationCollectorCodeVisitor.java 91.5584% <75.0000%> (-1.8190%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eric-milles eric-milles merged commit d51a0b6 into master May 12, 2025
41 checks passed
@eric-milles eric-milles deleted the GROOVY-7439 branch May 12, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants